Let's go over the sharing settings which are generally messed up since they removed Homegroup has been removed in the latest version.
See here for how to share files and printers/scanners over network after removal of HomeGroup in Version 1803:
https://www.windowscentral.com/how-share-files-...
https://www.tenforums.com/tutorials/111783-shar...
https://www.windowscentral.com/how-access-files...
To troubleshoot sharing problems:
https://www.lifewire.com/troubleshooting-window...
https://windowsunplugged.blog/2018/03/27/networ...
https://www.thewindowsclub.com/network-computer...
https://superuser.com/questions/1202441/windows...
If you cannot get past the password protected sharing prompt:
https://www.isunshare.com/windows-10/fix-enter-...
https://www.speedguide.net/faq/windows-is-askin...
https://www.tenforums.com/network-sharing/61689...
If Windows 7 is involved make sure if applicable you have the WIndows Update released to fix Windows 7 sharing issues here:
https://www.bleepingcomputer.com/news/microsoft...
Test if turning off Controlled Folder access helps:
https://www.thewindowsclub.com/controlled-folde...
See these additional resources for when a PC does not show up on network:
http://woshub.com/network-computers-not-showing...
https://www.thewindowsclub.com/network-computer...
https://social.technet.microsoft.com/Forums/en-...
You may want to change to sharing via OneDrive:
https://www.computerworld.com/article/3256907/m...
If you want to sign into the same OneDrive account on all PC's then you can sync files by parking them in the OneDrive folder. You can also sync Documents, Pictures and Desktop folders between them using Folder Protection Backup here:
https://www.tenforums.com/tutorials/116029-turn.... This moves those User folders into the OneDrive folder, but it can be done for all User folders from their Properties > Location tab if desired as shown here:
http://answers.microsoft.com/en-us/windows/wiki... .
If you want to express your opinion on this to Microsoft use the Feedback Hub app in Start Menu where developers are tasked to process consumer feedback. They will not even see it here. This is a tech forums staffed mostly by volunteers trying to help others with your problems.
If you want to post back a Share link from your Feedback here others who see this thread can vote it up and add to it.
I hope this helps. Feel free to ask back any questions and let us know how it goes. I will keep working with you until it's resolved.
________________________________________________________
Standard Disclaimer: There are links to non-Microsoft websites. The pages appear to be providing accurate, safe information. Watch out for ads on the sites that may advertise products frequently classified as a PUP (Potentially Unwanted Products). Thoroughly research any product advertised on the sites before you decide to download and install it.